Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial version bump action #5187

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Initial version bump action #5187

merged 1 commit into from
Jul 24, 2024

Conversation

AustinSanders
Copy link
Contributor

Creates a bot to bump version on specified branch. Currently set to fake "lts" branch. Will need to be updated when LTS branches are released.

Description

Bumps patch version specified in meta.yaml and cmakelists.txt.

I'm a noob at awk/sed, so there's probably a better way to hit this regex. It was a difficult for me to balance generality and specificity.

Related Issue

LTS Release + CI/CD work

How Has This Been Validated?

Bot commit visible at AustinSanders@29f55d1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@chkim-usgs
Copy link
Contributor

Looks good, question though: do version updates to the code.json and CHANGELOG.md have different qualifications for them to occur? Or would these updates happen in a different step of the pipeline?

@github-actions GitHub Actions
Copy link

Thank you for your contribution!

Unfortunately, this pull request hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this pull request will be automatically closed in 180 days.

If you want to participate in our support prioritization meetings or be notified when support sprints are happening, you can sign up the support sprint notification emails here.

Read more about our support processs here

@github-actions github-actions bot added the inactive Issue that has been inactive for at least 6 months label Feb 22, 2024
@AustinSanders
Copy link
Contributor Author

Looks good, question though: do version updates to the code.json and CHANGELOG.md have different qualifications for them to occur? Or would these updates happen in a different step of the pipeline?

I think I can add code.json here, but I think the changelog should be updated in a different job. The idea is that this will be run when something is merged into the LTS branch, and the triggering commit will likely already include an updated changelog, so I'm viewing it as a separate step.

@amystamile-usgs
Copy link
Contributor

@chkim-usgs Do you have time to review this? Not sure if this is waiting on another CI sprint or if it's okay to merge now.

@chkim-usgs
Copy link
Contributor

@AustinSanders, I think it looks good, incrementing the patch version whenever the bot is triggered. Are there any other version updates that can affect this PR since it has been open? Only thing that comes to mind is the new isis_version.txt but that seems to be generated after.

@github-actions github-actions bot removed the inactive Issue that has been inactive for at least 6 months label Jul 18, 2024
@AustinSanders
Copy link
Contributor Author

I don't think any of the changes that we've made will affect the way that this bot works. This grabs the version number from meta.yml, increments, and overwrites the version number in meta.yml + cmakelists.txt

@amystamile-usgs amystamile-usgs merged commit 58d4985 into DOI-USGS:dev Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chkim-usgs chkim-usgs chkim-usgs approved these changes

@acpaquette acpaquette Awaiting requested review from acpaquette

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AustinSanders @chkim-usgs @amystamile-usgs